First pass at client filtering #93
clippy-all-features
6 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 6 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.83.0 (90b35a623 2024-11-26)
- cargo 1.83.0 (5ffbef321 2024-10-29)
- clippy 0.1.83 (90b35a6 2024-11-26)
Annotations
Check failure on line 67 in crates/relayer-types/src/utils/pretty.rs
github-actions / clippy-all-features
the following explicit lifetimes could be elided: 'a
error: the following explicit lifetimes could be elided: 'a
--> crates/relayer-types/src/utils/pretty.rs:67:6
|
67 | impl<'a, T: Display> Display for PrettySlice<'a, T> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
67 - impl<'a, T: Display> Display for PrettySlice<'a, T> {
67 + impl<T: Display> Display for PrettySlice<'_, T> {
|
Check failure on line 18 in crates/relayer-types/src/utils/pretty.rs
github-actions / clippy-all-features
the following explicit lifetimes could be elided: 'a
error: the following explicit lifetimes could be elided: 'a
--> crates/relayer-types/src/utils/pretty.rs:18:6
|
18 | impl<'a, T: Display> Display for PrettyOption<'a, T> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
18 - impl<'a, T: Display> Display for PrettyOption<'a, T> {
18 + impl<T: Display> Display for PrettyOption<'_, T> {
|
Check failure on line 135 in crates/relayer-types/src/core/ics04_channel/packet.rs
github-actions / clippy-all-features
the following explicit lifetimes could be elided: 'a
error: the following explicit lifetimes could be elided: 'a
--> crates/relayer-types/src/core/ics04_channel/packet.rs:135:6
|
135 | impl<'a> core::fmt::Debug for PacketData<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
135 - impl<'a> core::fmt::Debug for PacketData<'a> {
135 + impl core::fmt::Debug for PacketData<'_> {
|
Check failure on line 398 in crates/relayer-types/src/core/ics03_connection/connection.rs
github-actions / clippy-all-features
function cannot return without recursing
error: function cannot return without recursing
--> crates/relayer-types/src/core/ics03_connection/connection.rs:396:5
|
396 | / fn from(value: State) -> Self {
397 | | value.into()
398 | | }
| |_____^
|
note: recursive call site
--> crates/relayer-types/src/core/ics03_connection/connection.rs:397:9
|
397 | value.into()
| ^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unconditional_recursion
= note: `-D clippy::unconditional-recursion` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unconditional_recursion)]`
Check failure on line 5 in crates/relayer-types/src/core/ics03_connection/connection.rs
github-actions / clippy-all-features
importing legacy numeric constants
error: importing legacy numeric constants
--> crates/relayer-types/src/core/ics03_connection/connection.rs:5:5
|
5 | u64,
| ^^^
|
= help: remove this import
= note: then `u64::<CONST>` will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `-D clippy::legacy-numeric-constants` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::legacy_numeric_constants)]`
Check failure on line 222 in crates/relayer-types/src/core/ics02_client/trust_threshold.rs
github-actions / clippy-all-features
the following explicit lifetimes could be elided: 'de
error: the following explicit lifetimes could be elided: 'de
--> crates/relayer-types/src/core/ics02_client/trust_threshold.rs:222:10
|
222 | impl<'de> Visitor<'de> for StringOrInt {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `-D clippy::needless-lifetimes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
|
222 - impl<'de> Visitor<'de> for StringOrInt {
222 + impl Visitor<'_> for StringOrInt {
|