use prost::Name trait instead of TypeUrl
#3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
|
|
redshiftzero
force-pushed
the
prost-name
branch
from
1164218 to
8c5f31f
Compare
redshiftzero
had a problem deploying
to
smoke-test
GitHub Actions
Failure
redshiftzero
force-pushed
the
prost-name
branch
2 times, most recently
from
c1366d9 to
d0e4fc7
Compare
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
changed the title
prost::Name trait instead of TypeUrlprost::Name trait instead of TypeUrl
cronokirby
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
One thing to note is that I think this is breaking because we lose the leading slash on the name.
Also, I haven't literally looked at every file, but it seems that the process here was just removing impl TypeUrl everywhere, and then using the prost::Name trait instead, so that seems fine.
Yes, also because a bunch of our URLs were outdated since I didn't fix them while rearranging all the protos. |
This release of prost includes the support for auto-generated names: tokio-rs/prost#926
redshiftzero
force-pushed
the
prost-name
branch
from
fe003e5 to
29654ab
Compare
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3330
Closes #3380
@erwanor flagged that we also need cosmos/ibc-proto-rs#163 to completely migrate away from TypeUrl
Remaining TODOs: