-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare testnet 75 #4375
Conversation
Makes three substantive changes: * resets `TOTAL_HALT_COUNT` to 0 * increments `APP_VERSION` * increments chain_id `penumbra-testnet-deimos-7` -> `penumbra-testnet-deimos-8` There are multiple chain id directories included, pulled from the `release/v0.73.2` tag. Due to our multi-branch workflow, we never backported those testnet configs to the main branch, but doing so is necessary now that we're releasing from main again. Refs #4374.
@@ -3,3 +3,4 @@ | |||
| 1 (Testnet 70) | v0.70.x | v0.37.5 | v1 | | |||
| 2 (Testnet 73) | v0.73.x | v0.37.5 | v1 | | |||
| 3 (Testnet 74) | v0.74.x | v0.37.5 | v1 | | |||
| 4 (Testnet 75) | v0.75.x | v0.37.5 | v1 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping crate version only in the COMPAT doc for now. Post-merge, we'll bump-and-tag directly on the main branch, to trigger the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are multiple chain id directories included, pulled from the release/v0.73.2 tag. Due to our multi-branch workflow, we never backported those testnet configs to the main branch, but doing so is necessary now that we're releasing from main again.
thanks for explaining the backing context. this looks great.
one non-blocking question, since github review does not provide a nice way to hang comments on a parent directory: for extra clarity, i might suggest that we leave e.g. an empty tombstone / stub directory, |
This is a good suggestion! There are similar events would could backfill for posterity. The testnet dirs themselves are machine-readable, and their contents are baked into binaries, so I'd prefer to keep READMEs out of band. But a file in |
ah-ha! that is very good to know, had not realized these directories are machine-readable. knowing that, i agree with that plan of action. thank you for elaborating! |
Describe your changes
Makes three substantive changes:
TOTAL_HALT_COUNT
to 0APP_VERSION
penumbra-testnet-deimos-7
->penumbra-testnet-deimos-8
There are multiple chain id directories included, pulled from the
release/v0.73.2
tag. Due to our multi-branch workflow, we never backported those testnet configs to the main branch, but doing so is necessary now that we're releasing from main again.Refs #4374.
Issue ticket number and link
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: