test(pd): add integration test for grpc reflection #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft because I cobbled this together as part of initial work on #4392, and it proved useful while reviewing #4424 & #4425. Still needs some attention in getting CI working, and also pulling in the FILE_DESCRIPTOR set from the proto crate. Will circle back on it opportunistically next time I'm waiting on a long build. |
conorsch
force-pushed
the
4392-regression-test-for-reflection
branch
from
08f60ec
to
ad9a444
Compare
conorsch
force-pushed
the
4392-regression-test-for-reflection
branch
from
ad9a444
to
850c973
Compare
conorsch
force-pushed
the
4392-regression-test-for-reflection
branch
from
850c973
to
46ab3e8
Compare
conorsch
commented
May 23, 2024
| @@ -28,6 +28,9 @@ jobs: | |||
| sh -c "$(curl --location https://raw.githubusercontent.com/F1bonacc1/process-compose/main/scripts/get-pc.sh)" -- | |||
| -d -b ~/bin | |||
|
|
|||
| - name: Install grpcurl | |||
| run: ./deployments/scripts/install-grpcurl | |||
|
|
|||
Refs #4392. We want to ensure that server reflection remains working, despite changes to the tonic dependencies (#4400) and proto compiling logic #4422. While the most effective test is exercising all these protos regularly, we currently lack solid coverage, so this superficial integration test is a sanity-check to save time versus building locally and inspecting the output manually.
conorsch
force-pushed
the
4392-regression-test-for-reflection
branch
from
46ab3e8
to
711494d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Refs #4392. We want to ensure that server reflection remains working, despite changes to the tonic dependencies (#4400) and proto compiling logic #4422. While the most effective test is exercising all these protos regularly, we currently lack solid coverage, so this superficial integration test is a sanity-check to save time versus building locally and inspecting the output manually.
Issue ticket number and link
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: