backport fixes to planner gas prices & validator voting #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Describe your changes Resolves #4507. ## Checklist before requesting a review - [X] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > This is purely a client change. (cherry picked from commit 1c96f34)
Closes #4555 and fixes fee inclusion in validator definition upload, validator vote casting, and tx sweep. This also introduces some protection for future planner invocations. The `Planner`'s `gas_prices` field has been changed to an `Option` type and if it's not set it will return an error during planning: ``` $ cargo run --bin pcli --release -- --home ~/.local/share/pcli-preview/ validator definition upload --file validator.toml ... Error: planner instances must call set_gas_prices prior to planning ``` --------- Co-authored-by: Tal Derei <talderei99@gmail.com> Co-authored-by: Chris Czub <chris@penumbralabs.xyz> (cherry picked from commit 77f3f22)
cronokirby
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Backports two PRs for 0.77.2 (#4545):
The planner changes in the latter are crucial to point-release. The former less so, but including those changes reduced conflicts on the cherry-pick, and the client-side improvement is a nice-to-have as we focus on resolving #4540.
Issue ticket number and link
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: