Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't run long tests on docs-only PRs #4562

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Jun 4, 2024

Describe your changes

I want to keep the docs up to date, and sometimes that requires fussy management of version numbers, particularly as we invest in multi-branch workflows to support point releases (e.g. #4545). If only the docs changed, skip the long-running rust tests, because we don't need to validate rust functionality on docs changes.

Issue ticket number and link

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    ci-only

I want to keep the docs up to date, and sometimes that requires fussy
management of version numbers, particularly as we invest in multi-branch
workflows to support point releases (e.g. #4545). If *only* the docs
changed, skip the long-running rust tests, because we don't need to
validate rust functionality on docs changes.
@conorsch conorsch force-pushed the ci-no-rust-tests-on-docs-changes branch from 76ec232 to 2a739ab Compare June 4, 2024 23:31
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 amazing! thank you for this!

@conorsch conorsch merged commit 8296243 into main Jun 5, 2024
13 checks passed
@conorsch conorsch deleted the ci-no-rust-tests-on-docs-changes branch June 5, 2024 15:23
conorsch added a commit that referenced this pull request Jun 20, 2024
Refs #4648. Also, given #4562, CI should be fast on this PR.
conorsch added a commit that referenced this pull request Jun 20, 2024
Refs #4648. Also, given #4562, CI should be fast on this PR.
conorsch added a commit that referenced this pull request Jun 20, 2024
Refs #4648. Also, given #4562, CI should be fast on this PR.
avahowell pushed a commit that referenced this pull request Jun 24, 2024
Refs #4648. Also, given #4562, CI should be fast on this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants