This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
ci: run dynamic server in container #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to run and debug the container build, the workflow must exist on |
We've been hosting the dapp as a static website, but the developers have maintained it as a single-page application (SPA). Let's update the containerfile to handle hosting the app so we can deploy via container image. It's not ideal to use the webpack dev server for this use case, but I'm prioritizing getting something up and running to unbreak the extension for testnet users.
conorsch
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been hosting the dapp as a static website, but the developers have maintained it as a single-page application (SPA). Let's update the containerfile to handle hosting the app so we can deploy via container image. It's not ideal to use the webpack dev server for this use case, but I'm prioritizing getting something up and running to unbreak the extension for testnet users.