Add Ics20Withdrawal info to tx approval popup

penumbra-zone · Mar 20, 2024 · b027fdf · b027fdf
1 parent d4637a8
commit b027fdf
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 7 deletions.
diff --git a/apps/extension/src/routes/popup/approval/transaction/index.tsx b/apps/extension/src/routes/popup/approval/transaction/index.tsx
@@ -33,8 +33,8 @@ export const TransactionApproval = () => {
 
   return (
     <div className='flex h-screen flex-col justify-between'>
-      <div className='grow overflow-auto p-[30px] pt-10'>
-        <p className='bg-text-linear bg-clip-text font-headline text-2xl font-bold text-transparent'>
+      <div className='grow overflow-auto p-[30px] pb-44 pt-10'>
+        <p className='bg-text-linear bg-clip-text pb-2 font-headline text-2xl font-bold text-transparent'>
           Confirm transaction
         </p>
 

diff --git a/packages/perspective/plan/view-action-plan.test.ts b/packages/perspective/plan/view-action-plan.test.ts
@@ -427,7 +427,7 @@ describe('viewActionPlan()', () => {
   });
 
   describe('`withdrawal` action', () => {
-    test('returns an action view with the `ics20Withdrawal` case and no value', () => {
+    test('returns an action view with the `ics20Withdrawal` case as-is', () => {
       const actionPlan = new ActionPlan({
         action: {
           case: 'ics20Withdrawal',
@@ -442,7 +442,7 @@ describe('viewActionPlan()', () => {
           new ActionView({
             actionView: {
               case: 'ics20Withdrawal',
-              value: {},
+              value: { amount: { hi: 1n, lo: 0n } },
             },
           }),
         ),

diff --git a/packages/perspective/plan/view-action-plan.ts b/packages/perspective/plan/view-action-plan.ts
@@ -213,7 +213,7 @@ export const viewActionPlan =
         return new ActionView({
           actionView: {
             case: 'ics20Withdrawal',
-            value: {},
+            value: actionPlan.action.value,
           },
         });
       case 'delegate':

diff --git a/packages/perspective/translators/action-view.ts b/packages/perspective/translators/action-view.ts
@@ -25,6 +25,7 @@ export const asPublicActionView: Translator<ActionView> = actionView => {
     case 'delegate':
     case 'undelegate':
     case 'undelegateClaim':
+    case 'ics20Withdrawal':
       return actionView;
 
     default:

diff --git a/packages/ui/components/ui/tx/view/memo-view.tsx b/packages/ui/components/ui/tx/view/memo-view.tsx
@@ -10,8 +10,12 @@ export const MemoViewComponent = ({ memo: { memoView } }: { memo: MemoView }) =>
           <ViewBox
             label='Memo Text'
             visibleContent={
-              // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
-              <div>{memoView.value.plaintext?.text || '&nbsp;'}</div>
+              <div>
+                {/* eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing */}
+                {memoView.value.plaintext?.text || (
+                  <span className='italic text-gray-600'>== none ==</span>
+                )}
+              </div>
             }
           />
           <ViewBox