Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-asset fees support in minifront #1165

Closed
TalDerei opened this issue May 24, 2024 · 2 comments
Closed

multi-asset fees support in minifront #1165

TalDerei opened this issue May 24, 2024 · 2 comments
Assignees
Labels
enhancement refactor Improving existing system with new design ui Related to user interface or ux design wasm Rust crate updates

Comments

@TalDerei
Copy link
Contributor

TalDerei commented May 24, 2024

We have multi-asset fee support at the protocol level, and the web planner implementation has achieved parity with core. There are supplemental UX changes that need to be implemented to fully realize this.

Logic:

  • if the user has UM, use that for fees
  • otherwise, use the first alt fee token that they have balance of
    • tx approval warns about non-native fees as a privacy risk and recommends using native token
  • otherwise, error that they have no available fee tokens
@TalDerei TalDerei added ui Related to user interface or ux design mainnet labels May 24, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web May 24, 2024
@grod220
Copy link
Collaborator

grod220 commented May 28, 2024

Updated the description a bit. The Fee denom gets set to staking token in the default() initialization:

let mut actions_list = ActionList::default();

It looks like, before this, we need to check for balances of UM. If none, initialize ActionList with the alt denom and I believe the methods below should work as is (?). Definitely needs testing out. Also, transaction_parameters needs likewise updating.

@grod220 grod220 removed the mainnet label May 29, 2024
@grod220 grod220 moved this from 🗄️ Backlog to 🏗 In progress in Penumbra web Jun 3, 2024
@TalDerei
Copy link
Contributor Author

TalDerei commented Jun 8, 2024

folding in #1265 as relevant scope

@TalDerei TalDerei added the refactor Improving existing system with new design label Jun 8, 2024
@TalDerei TalDerei added wasm Rust crate updates enhancement labels Jun 17, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Penumbra web Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement refactor Improving existing system with new design ui Related to user interface or ux design wasm Rust crate updates
Projects
Archived in project
Development

No branches or pull requests

2 participants