Fee extraction tests + refactor #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9e09226 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
grod220
force-pushed
the
fee-extraction-tests
branch
from
5cfdb0d to
9e09226
Compare
grod220
commented
Jul 2, 2024
There was a problem hiding this comment.
For this file, focused on trying to accomplish the equivalent logic without manual type casting. Also, used map+find to cover cases where asset ids may be on some notes and not others of the same category.
TalDerei
approved these changes
Jul 2, 2024
Comment on lines
+6
to
+8
| export const extractAltFee = (request: TransactionPlannerRequest): AssetId => { | ||
| const outputAsset = request.outputs.map(o => o.value?.assetId).find(Boolean); | ||
| if (outputAsset) return outputAsset; |
There was a problem hiding this comment.
I quite like this map + find pattern here. I manually confirmed that the logic is equivalent.
| import { extractAltFee } from './fees'; | ||
| import { AuctionId } from '@buf/penumbra-zone_penumbra.bufbuild_es/penumbra/core/component/auction/v1/auction_pb'; | ||
|
|
||
| describe('extractAltFee', () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some follow up after #1165
After pairing with @vacekj, noticed a few areas of improvement with type checking + test coverage