Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi-asset fee bug #1397

Closed
TalDerei opened this issue Jul 2, 2024 · 2 comments · Fixed by #1412
Closed

multi-asset fee bug #1397

TalDerei opened this issue Jul 2, 2024 · 2 comments · Fixed by #1412
Assignees
@Valentine1898 @TalDerei
Labels
bug Something isn't working

Comments

@TalDerei
Copy link
Contributor

TalDerei commented Jul 2, 2024 •
edited
Loading

for swaps / auctions, figure out why the multi-asset fees (enabled when the user does not have native UM tokens) sometimes works for swapping one asset into another, but not vice versa

Screen.Recording.2024-07-02.at.10.10.24.AM.mov
Screen.Recording.2024-07-02.at.10.10.55.AM.mov
@TalDerei TalDerei added the bug Something isn't working label Jul 2, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Jul 2, 2024
@TalDerei TalDerei added this to Labs web Jul 2, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Labs web Jul 2, 2024
@TalDerei TalDerei self-assigned this Jul 2, 2024
@TalDerei TalDerei moved this from 🗄️ Backlog to 📝 Todo in Labs web Jul 2, 2024
@TalDerei TalDerei moved this from 📝 Todo to 🏗 In progress in Labs web Jul 3, 2024
@Valentine1898
Copy link
Contributor

related to #1310
The native token's gas prices are used each time, so for exponent tokens with an exponent less than UM (e.g. CUBE or PIZZA), the planner attempts to spend a large amount as a fee

This was referenced Jul 3, 2024
Closed
Merged
@TalDerei
Copy link
Contributor Author

TalDerei commented Jul 4, 2024

closing in favor of #1413

@TalDerei TalDerei closed this as completed Jul 4, 2024
@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Penumbra web Jul 4, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Labs web Jul 4, 2024
@TalDerei TalDerei mentioned this issue Jul 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Valentine1898 Valentine1898

@TalDerei TalDerei

Labels
bug Something isn't working
Projects
Penumbra web
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1310 modify gasprices storage to support multi asset fees penumbra-zone/web
2 participants
@Valentine1898 @TalDerei