-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify GasPrices
storage to support multi-asset fees
#1310
Labels
rpc
Related to proto rpc services/methods
Comments
TalDerei
added a commit
that referenced
this issue
Jun 17, 2024
* add index for spendable notes table in idb * scaffolding planner support for multi-asset fees * filter for alt fee asset id * fix fee rendering * full multi-asset fee support ~ * attempt to pass CI * partially address comments * valentine + jesse feedback * fix broken lockfile, update deps, update db version * remove dangling minifront_url * co-locate idb version with storage package * remove idb version from extension .env * support actions for alt fees * linting and organization cleanup * update lockfile * remove extension dir trace * fix lockfile? * address valentine comments * fix test suite * try fixing rust tests * rust lint * rust lint * add TODOs for #1310 * fix lint --------- Co-authored-by: valentine <valentyn1789@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
You are right,
GasPrices
does contain anasset_id
, I missed that becauseasset_id
is never defined.But the problem is that our
GasPrices
storage is deprecated and not suitable for multi-asset feesNow we store
GasPrices
assuming that we can only have one recordInstead, we should use the
assetId
as the keyBut in that case, I expect we'll run into an error, because pd purposely omits the assetId for native
GasPrices
, but that's bad for us, because undefined can't be a key in indexed-dbWe will have to manually add the
assetId
for nativeGasPrices
or come up with another trickAlso, note that the getGasPrices function will also have to be modified
Also need to change the gasPrices rpc for the view service so that it retrieves
alt_gas_prices
And the block processor logic that should save
alt_gas_prices
to indexed-db when neededOriginally posted by @Valentine1898 in #1268 (comment)
The text was updated successfully, but these errors were encountered: