Insert missing asset IDs for ActionDutchAuctionSchedule #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepinho
commented
May 4, 2024
Comment on lines
+345
to
+351
| ActionView::ActionDutchAuctionSchedule(ActionDutchAuctionScheduleView { | ||
| action, | ||
| .. | ||
| }) => { | ||
| asset_ids.insert(action.description.output_id); | ||
| asset_ids.insert(action.description.input.asset_id); | ||
| } |
There was a problem hiding this comment.
This is a part of a match statement inside transaction_info_inner, in which we iterate over each action in the transaction, adding relevant pieces of information to the transaction perspective that will be needed to generate the transaction view. In this case, we need to add the asset IDs used for the auction to asset_ids, so that later on in this function, we can fetch those assets' metadata.
jessepinho
requested review from
TalDerei,
grod220,
erwanor,
Valentine1898 and
turbocrime
TalDerei
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
(Note that the input metadata was present because the TXP had been filled with that metadata when processing the "Spend" action. However, we don't want to rely on that.)
After
Punting to future PRs
*Withdraw/*Endactions. Punting for now since that flow isn't yet supported on web.