Update WASM crate to point to SHA of core that includes correct middleware #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepinho
force-pushed
the
jessepinho/auctions-query-latest-state-fix-web-980
branch
from
060e5fc to
7dae064
Compare
jessepinho
commented
May 8, 2024
| @@ -91,7 +91,7 @@ impl ActionList { | |||
| } | |||
|
|
|||
| fn fee_estimate(&self, gas_prices: &GasPrices, fee_tier: &FeeTier) -> Fee { | |||
| let base_fee = Fee::from_staking_token_amount(gas_prices.fee(&self.gas_estimate())); | |||
| let base_fee = gas_prices.fee(&self.gas_estimate()); | |||
There was a problem hiding this comment.
GasPrices::fee() now returns a Fee instead of an Amount. I figured Fee::from_staking_token_amount() isn't needed, since the fee from a GasPrices should always be in the staking token.
There was a problem hiding this comment.
planner logic will need to change again, so that's alright
jessepinho
commented
May 8, 2024
| @@ -538,14 +538,14 @@ pub async fn plan_transaction( | |||
| }; | |||
|
|
|||
| if let Some(pb_memo_plaintext) = request.memo { | |||
| plan.memo = Some(MemoPlan::new(&mut OsRng, pb_memo_plaintext.try_into()?)?); | |||
| plan.memo = Some(MemoPlan::new(&mut OsRng, pb_memo_plaintext.try_into()?)); | |||
There was a problem hiding this comment.
Getting rid of the final ? since it's no longer needed
jessepinho
force-pushed
the
jessepinho/auctions-query-latest-state-fix-web-980
branch
from
7dae064 to
b8f7b14
Compare
jessepinho
force-pushed
the
jessepinho/auctions-query-latest-state-fix-web-980
branch
from
b8f7b14 to
8fe0958
Compare
jessepinho
commented
May 8, 2024
| } | ||
| for action in self.change_outputs.values() { | ||
| // TODO missing AddAssign |
There was a problem hiding this comment.
jessepinho
requested review from
erwanor,
TalDerei,
grod220,
Valentine1898 and
turbocrime
grod220
approved these changes
May 9, 2024
|
We're doing a tagged release today and will bump the auction protos to |
TalDerei
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core was previously missing a necessary middleware for its auction endpoint. As a result, calls to that endpoint would fail due to a missing trailer.
This was recently fixed, so this PR points the WASM crate to the SHA that fixed that issue, so that calls to get the latest auction state from the fullnode will succeed.
This PR also addresses a couple typings changes from core that resulted from the update.