Fix unknown assets for ibc-out #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valentine1898
commented
May 9, 2024
| @@ -242,7 +243,6 @@ export const filterBalancesPerChain = ( | |||
| const assetIdsToCheck = [penumbraAssetId, ...assetsWithMatchingChannel]; | |||
|
|
|||
| return allBalances.filter(({ balanceView }) => { | |||
| const metadata = getMetadata(balanceView); | |||
| return assetIdsToCheck.some(assetId => assetId.equals(metadata.penumbraAssetId)); | |||
| return assetIdsToCheck.some(assetId => assetId.equals(getAssetIdFromValueView(balanceView))); | |||
There was a problem hiding this comment.
Unknown assets also have an assetId, but no metadata.
Theoretically, this code allows for an unknown asset to be sent via IBC. But in fact, we can never match an unknown asset with an asset from some ibc channel, because in this case the asset is available in the registry and cannot be an unknown asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ibc page is broken if you have unknown assets on your balance
