-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support compat addresses for ibc-in #1079
Conversation
f122d24
to
5ed0240
Compare
How long will the ibc transfer from noble take? |
Currently the client state has expired. We'll need to work with the protocol team in getting these back up before we get a successful transfer. However, after this PR, we are no longer getting the bech32 error like we had before. Thanks for testing though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to just penumbracompat.ts
to match other files in this dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But aren't these files named according to the prefix? For some reason, this prefix uniquely has the 1 in it: https://github.com/penumbra-zone/penumbra/blob/d13d731fadd665d7f2ec38c3bde57f53b2e86891/crates/proto/src/serializers/bech32str.rs#L146
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also wonder if it has this number in it because we may need to have penumbracompat2
for some other chain in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting. 1 is a valid prefix character, but it is also the separator character, and this may be a bug in core or has some unexplained meaning like version as you suggest.
i can't find any examples or documentation on this.
cc @avahowell you committed the penumbracompat1
in core?
suggestions in #1083 |
5ed0240
to
cd828cc
Compare
cd828cc
to
23bc671
Compare
Closes #1053
For noble, we need to encode our addresses to bech32 (not bech32m). In core, we have a special prefix for this specific case: https://github.com/penumbra-zone/penumbra/blob/main/crates/proto/src/serializers/bech32str.rs#L146.
Amended our bech32m package to support this new encoding method.