Redesign Duration display for Dutch auctions with live-updating price visualization. #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepinho
force-pushed
the
jessepinho/redesign-duration-web-1088
branch
from
5b5e865 to
6b6c273
Compare
jessepinho
force-pushed
the
jessepinho/redesign-duration-web-1088
branch
from
6b6c273 to
f481c41
Compare
jessepinho
force-pushed
the
jessepinho/redesign-duration-web-1088
branch
from
f481c41 to
3696baa
Compare
jessepinho
commented
May 11, 2024
| size='sm' | ||
| className='mt-2' | ||
| /> | ||
| <div className='mt-2'> |
There was a problem hiding this comment.
I removed className from <Progress />'s props, so we need to wrap it in a div with a margin-top.
jessepinho
changed the title
grod220
approved these changes
May 13, 2024
There was a problem hiding this comment.
Ah! Another case for #965.
Comment on lines
49
to
50
| const p = targetOutputScaled; | ||
| const q = inputScaled; |
There was a problem hiding this comment.
Do we need these reassigned? Can we just use targetOutputScaled and inputScaled inline below?
There was a problem hiding this comment.
Ah, good catch — this was a leftover from copying core's implementation.
| @@ -0,0 +1,16 @@ | |||
| const clampToDecimal = (value: number) => Math.min(Math.max(value, 0), 1); | |||
There was a problem hiding this comment.
What does clamp mean here? Maybe a code comment here? (same in other usage too)
There was a problem hiding this comment.
Clamping refers to limiting a value between a given min and max. Will add a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrub through this video to get a timelapse of part of a 10-minute auction.
Screen.Recording.2024-05-10.at.5.41.55.PM.mov
This is a bit of a frilly PR that I prob shouldn't have spent as much time on as I did... Basically it visualizes to the user what the current price is of the input asset in terms of the output asset, as well as how far along we are in the auction.
Again, this is by no means a finalized design, but it's at least an improvement on what we had before.
In this PR
statusslice for storing the sync status (fullSyncHeightandlatestKnownBlockHeight) so it can be used both in the header and in places like Dutch auctions.<Progress />to only accept a few specific props, rather than the full default set (which we neither need nor want).<AssetIcon />and<ValueViewComponent />.Closes #1088