Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idb plainmessage gasprices #1121

Merged
merged 6 commits into from
May 16, 2024
Merged

idb plainmessage gasprices #1121

merged 6 commits into from
May 16, 2024

Conversation

turbocrime
Copy link
Contributor

Copy link

changeset-bot bot commented May 16, 2024

⚠️ No Changeset found

Latest commit: 700e61e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TalDerei TalDerei self-requested a review May 16, 2024 18:16
@TalDerei
Copy link
Contributor

TalDerei commented May 16, 2024

@turbocrime bumped idb version to enable gas fees on web. no changes need to be made to initGasPrices

when penumbra-zone/penumbra#4306 is merged, the gas prices will be enabled on testnet and the pb message in a single incoming compact block will not be undefined, and saveGasPrices will be called.

@TalDerei TalDerei marked this pull request as ready for review May 16, 2024 18:16
@TalDerei
Copy link
Contributor

For context and visibility, the flow is:

  1. Bump IDB version, clearing the database on upgrade,
  2. Manually set default gas prices on indexDB initialization,
  3. initGasPrices will only be called once on initialization, and condition will fail on subsequent extension startups,
  4. Once non-zero gas fees are enabled in core, a single compact block's pb message will have a gasPrices field that won't be undefined,
  5. In the block processor, it will call saveGasPrices and override the default value in indexDB,
  6. remove the initGasPrices call

@TalDerei TalDerei self-assigned this May 16, 2024
@TalDerei TalDerei merged commit 010bd1f into main May 16, 2024
6 checks passed
@TalDerei TalDerei deleted the turbocrime/plainmessage-gasprices branch May 16, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants