Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with how error splash page was rendered #1131

Merged
merged 2 commits into from
May 18, 2024
Merged

Fix issue with how error splash page was rendered #1131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1277e69
Fix issue with how error was rendered
jessepinho May 17, 2024
5636a55
Add changeset
jessepinho May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cool-bats-change.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'minifront': patch
---

Fix error splash screen
2 changes: 0 additions & 2 deletions apps/minifront/src/components/root-router.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,10 @@ export const rootRouter = createHashRouter([
index: true,
loader: AssetsLoader,
element: <AssetsTable />,
errorElement: <ErrorBoundary />,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding error boundaries lower down in the route tree means that the error boundary will render within that route's <Outlet />. I've removed these so that all errors bubble up to the top-level boundary.

},
{
path: PagePath.TRANSACTIONS,
element: <TransactionTable />,
errorElement: <ErrorBoundary />,
},
],
},
Expand Down
Loading