Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to using IDB_VERSION defined inside the package #1341

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

Valentine1898
Copy link
Contributor

closes #1332

@Valentine1898 Valentine1898 linked an issue Jun 20, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: ca21f76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@penumbra-zone/storage Major
@penumbra-zone/services Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines 101 to 100
it('increasing version should re-create object stores', async () => {
it.skip('increasing version should re-create object stores', async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vitest-dev/vitest#5765
vi.mock are still not available in browser mode, so you should disable this test until the next stable version of vitest is published.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a code comment just as you described here above that test?

@Valentine1898 Valentine1898 requested a review from a team June 20, 2024 02:02
Copy link
Collaborator

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also just confirm that DB_VERSION = 43 is the correct version or whether we should bump to 44 🙏

Comment on lines 101 to 100
it('increasing version should re-create object stores', async () => {
it.skip('increasing version should re-create object stores', async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a code comment just as you described here above that test?

@Valentine1898
Copy link
Contributor Author

Can you also just confirm that DB_VERSION = 43 is the correct version or whether we should bump to 44 🙏

The current version, 43, is correct. The latest version defined in the extension's .env file is 42.

https://github.com/prax-wallet/web/blob/e9b0d0d3431f3b7756a19ff1c9c47dbc157d4bc6/apps/extension/.env#L1

@Valentine1898 Valentine1898 merged commit c555df7 into main Jun 20, 2024
6 checks passed
@Valentine1898 Valentine1898 deleted the 1332-needs-idb-version-bump branch June 20, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

needs idb version bump
2 participants