-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to using IDB_VERSION defined inside the package #1341
Conversation
🦋 Changeset detectedLatest commit: ca21f76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
it('increasing version should re-create object stores', async () => { | ||
it.skip('increasing version should re-create object stores', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vitest-dev/vitest#5765
vi.mock
are still not available in browser mode, so you should disable this test until the next stable version of vitest is published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a code comment just as you described here above that test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also just confirm that DB_VERSION = 43
is the correct version or whether we should bump to 44 🙏
it('increasing version should re-create object stores', async () => { | ||
it.skip('increasing version should re-create object stores', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a code comment just as you described here above that test?
The current version, 43, is correct. The latest version defined in the extension's |
closes #1332