Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send privacy warning animation #1463

Merged
merged 3 commits into from
Jul 11, 2024
Merged

fix: send privacy warning animation #1463

merged 3 commits into from
Jul 11, 2024

Conversation

vacekj
Copy link
Member

@vacekj vacekj commented Jul 10, 2024

fixes #1290

@vacekj vacekj linked an issue Jul 10, 2024 that may be closed by this pull request
fix animation related to privacy warning message #1290
Closed
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f362db6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vacekj vacekj changed the title fix: always show fee value in Send fix: send privacy warning animation Jul 10, 2024
jessepinho
jessepinho approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@jessepinho jessepinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I made one suggestion about condensing the conditional, but feel free to merge after addressing

@TalDerei TalDerei self-requested a review July 11, 2024 06:09
@vacekj vacekj merged commit fa33753 into main Jul 11, 2024
@vacekj vacekj deleted the 1290-fix-animation-related-to-privacy-warning-message branch July 11, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalDerei TalDerei TalDerei left review comments

@jessepinho jessepinho jessepinho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix animation related to privacy warning message
3 participants
@vacekj @jessepinho @TalDerei