Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for source in transaction planner request #1499

Merged
merged 2 commits into from
Jul 17, 2024
Merged

check for source in transaction planner request #1499

merged 2 commits into from
Jul 17, 2024

Conversation

TalDerei
Copy link
Contributor

references #1433

@TalDerei TalDerei self-assigned this Jul 17, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 92dcf82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 92dcf82):

https://penumbra-ui-preview--pr1499-transaction-source-02g3553q.web.app

(expires Wed, 24 Jul 2024 14:37:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

@TalDerei TalDerei requested a review from a team July 17, 2024 14:15
@TalDerei TalDerei changed the title check source in transaction request check for source in transaction planner request Jul 17, 2024
Valentine1898
Valentine1898 approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@Valentine1898 Valentine1898 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Does Minifront pass source in all cases?

Consider changing the buf documentation, as it may seem that source is not required
https://buf.build/penumbra-zone/penumbra/file/main:penumbra/view/v1/view.proto#L246

@TalDerei
Copy link
Contributor Author

Does Minifront pass source in all cases?

it does not, opened #1494

@TalDerei TalDerei merged commit 35ed14c into main Jul 17, 2024
8 checks passed
@TalDerei TalDerei deleted the transaction-source branch July 17, 2024 21:04
@turbocrime turbocrime mentioned this pull request Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valentine1898 Valentine1898 Valentine1898 approved these changes

Assignees

@TalDerei TalDerei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TalDerei @Valentine1898