wasm: witness tests #1876
Merged
wasm: witness tests #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1b8bf82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TalDerei
commented
Nov 20, 2024
Comment on lines
+293
to
+297
| // Modify the witness to use the default position. This will cause a failure | ||
| // because the position must be witnessed in the tree to be valid. | ||
| // | ||
| // It's unclear how to test this because this results in a panic deeper in the | ||
| // call stack that isn't propogated back to the caller? |
There was a problem hiding this comment.
tricky test case
There was a problem hiding this comment.
Wish we killed all panics 😢 and exclusively returned Result type...
grod220
approved these changes
Nov 20, 2024
Comment on lines
+293
to
+297
| // Modify the witness to use the default position. This will cause a failure | ||
| // because the position must be witnessed in the tree to be valid. | ||
| // | ||
| // It's unclear how to test this because this results in a panic deeper in the | ||
| // call stack that isn't propogated back to the caller? |
There was a problem hiding this comment.
Wish we killed all panics 😢 and exclusively returned Result type...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references #1831