Experiment with symbols for delegation tokens #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
reviewed
Feb 16, 2024
There was a problem hiding this comment.
I think it makes sense to do both of these methods. Either:
A) They are a known/trusted validator. We add them to our local registry list with their company logo in images array. This gets pre-loaded into our db.
B) They are an unknown validator. If a user has a delegation token from them, we don't find it in our db, so we assemble the metadata w/ the symbol in the block processor. If we can trust the id in metadata.display then we are safe.
You're taking off for holiday soon, happy to take this PR over on Monday if you'd like
Merged
grod220
force-pushed
the
delegation-token-symbol
branch
from
08b2860 to
ef98a2d
Compare
This PR experiments with symbols for delegation tokens. Two possible approaches are illustrated: 1. The extension's asset registry can be augmented with the validator-specific token info, as I did for the two main testnet validators. 2. The extension could auto-create a symbol for the delegation token, but we must be very very careful about this, because the `symbol` field is shown to users and it is potentially attacker-controlled. For instance, if we just read the label off the chain, someone could spoof another validator's identity without consequence. However, this seems like a good place to start.
This is better because it doesn't mislead the user into thinking that the number of tokens for the asset is the value of UM they represent.
grod220
force-pushed
the
delegation-token-symbol
branch
from
ef98a2d to
5551ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR experiments with symbols for delegation tokens. Two possible approaches are illustrated:
symbolfield is shown to users and it is potentially attacker-controlled. For instance, if we just read the label off the chain, someone could spoof another validator's identity without consequence.However, this seems like a good place to start.