Show a user's unstaked tokens on the validators page #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepinho
commented
Feb 21, 2024
Comment on lines
+28
to
+32
| <Card> | ||
| <CardHeader> | ||
| <CardTitle>Active validators</CardTitle> | ||
| </CardHeader> | ||
| <CardContent> |
There was a problem hiding this comment.
Only changes to this file are adding the <Card /> wrapper around the table.
jessepinho
changed the title
grod220
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Code looks good to me. But growing the page down with each additional piece of content in this tracking issue feels like it will get noisy fast.
Think our tab component is a good candidate for doing sub-routing on this page:
These tabs should match url routes like:
/staking/unstaked
/staking/staked
/staking/unbonding
/staking/validators
|
We should keep each category of staked funds on the same view, not split them across tabs. If we need to split up we should be splitting up by account, rather than interleaving, like I suggested in Discord. |
grod220
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step of reorganizing the Validators page to focus on tokens. See the tracking issue #463 for what's coming next.
This PR just displays the user's penumbra balances for any account that holds penumbra. In the upcoming PRs, I'll add delegation and unbonding tokens to each account, but I wanted to keep these PRs bite-sized.
Closes #586