Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't attempt to onboard at services init #774

Merged
merged 1 commit into from
Mar 15, 2024
Merged

don't attempt to onboard at services init #774

merged 1 commit into from
Mar 15, 2024

Conversation

turbocrime
Copy link
Contributor

@turbocrime turbocrime commented Mar 15, 2024 •
edited
Loading

@turbocrime turbocrime marked this pull request as ready for review March 15, 2024 18:35
@turbocrime
Copy link
Contributor Author

hard to tell, because this is dependent on the service worker being killed after a timeout, and some other unknown condition that restarts it

jessepinho
jessepinho approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@jessepinho jessepinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think — does this mean we're no longer going to automatically open the options page? (Does Chrome open it automatically the first time the extension is installed?)

@turbocrime
Copy link
Contributor Author

turbocrime commented Mar 15, 2024 •
edited
Loading

LGTM, I think — does this mean we're no longer going to automatically open the options page? (Does Chrome open it automatically the first time the extension is installed?)

it seems it is opened automatically on install and also the popup open would trigger it, in most cases. so the code was unnecessary

@turbocrime turbocrime merged commit 4f1171b into main Mar 15, 2024
6 checks passed
@turbocrime turbocrime deleted the turbocrime/focus-stealing-hotfix branch March 15, 2024 18:47
turbocrime added a commit that referenced this pull request Mar 15, 2024
@turbocrime
don't attempt to onboard at services init (#774)
e0f4829 
hotfix focus stealing bug
@turbocrime turbocrime self-assigned this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessepinho jessepinho jessepinho approved these changes

@grod220 grod220 Awaiting requested review from grod220

@hdevalence hdevalence Awaiting requested review from hdevalence

Assignees

@turbocrime turbocrime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbocrime @jessepinho