Use Array.fromAsync polyfill #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add declarations like b91d609 |
jessepinho
force-pushed
the
jessepinho/from-async-fix
branch
2 times, most recently
from
efcf717 to
32e25e3
Compare
Not sure why this is needed; hopefully we can remove it later.
jessepinho
force-pushed
the
jessepinho/from-async-fix
branch
from
32e25e3 to
0ffd570
Compare
turbocrime
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we'd assumed that Chrome supported Array.fromAsync, but only the last few versions of Chrome did (121+), and a lot of users are still on older versions. So this PR polyfills the implementation (not just the type) of
Array.fromAsyncin browsers where it doesn't yet exist.