Support NotLoggedIn status on connection page
#787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
force-pushed
the
connection-status
branch
from
de630ec to
020ee44
Compare
grod220
requested review from
jessepinho,
Valentine1898,
turbocrime and
TalDerei
|
might something like this, similar to when when a user tries to initiate a transaction when the wallet is locked, in red be cleaner? 
|
grod220
force-pushed
the
connection-status
branch
from
020ee44 to
41e1522
Compare
|
Now using toasts: 
|
turbocrime
suggested changes
Mar 19, 2024
turbocrime
force-pushed
the
connection-status
branch
from
41e1522 to
5be472c
Compare
turbocrime
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
cc @grod220 for approval
some of this diff is a bit larger than needs be
improved popup etc
importantly: failure reasons no longer prax-specific, part of client package
| @@ -1,3 +1,8 @@ | |||
| export enum PenumbraRequestFailure { | |||
There was a problem hiding this comment.
failure reasons not prax-specific
| @@ -1,37 +1,30 @@ | |||
| import { sessionExtStorage } from '@penumbra-zone/storage'; | |||
| import { PopupMessage, PopupRequest, PopupResponse, PopupType } from './message/popup'; | |||
| import { PopupMessage, PopupRequest, PopupType } from './message/popup'; | |||
There was a problem hiding this comment.
non-response handled in popup launcher
| @@ -61,6 +61,7 @@ export const createOriginApprovalSlice = (): SliceCreator<OriginApprovalSlice> = | |||
| data: { | |||
| choice, | |||
| origin: requestOrigin, | |||
| date: Date.now(), | |||
There was a problem hiding this comment.
slice just returns an actual complete record now
| void spawnExtensionPopup(popUrl.href); | ||
| throw new ConnectError('User must login to extension', Code.Unauthenticated); | ||
| } | ||
|
|
||
| switch (pop) { |
There was a problem hiding this comment.
needs login composable per popup type (future popups may not need it?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #775
We now handle the not-logged-in state and surface the error to the user on the connection page. After discussion in web weekly, agreed to simply throw error instead of handling login-redirect logic done in #772.