Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zustand race condition #788

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fix zustand race condition #788

merged 1 commit into from
Mar 18, 2024

Conversation

grod220
Copy link
Collaborator

@grod220 grod220 commented Mar 18, 2024

Closes #747

Checks first if a wallet is available before rendering UI. At the moment, zustand data loading from storage is sometimes slower than react rendering.

@@ -104,7 +104,7 @@ const FullySyncedState = ({ latestKnownBlockHeight, fullSyncHeight }: SyncingSta
width='50'
color='var(--teal)'
wrapperClass={cn(
'transition-all duration-300 absolute bottom-0 right-3',
'transition-all duration-300 absolute bottom-0 -left-7',
Copy link
Collaborator Author

@grod220 grod220 Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guy has been annoying me as well. With the fix, as the number grows, it will always be spaced out.

Screenshot 2024-03-18 at 9 16 06 PM

@grod220 grod220 merged commit 7cdd167 into main Mar 18, 2024
6 checks passed
@grod220 grod220 deleted the race-condition-zustand branch March 18, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zustand race condition
2 participants