Animate validators as they render #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepinho
force-pushed
the
jessepinho/animate-validator-rows-web-789
branch
from
ab5824a to
f607556
Compare
jessepinho
commented
Mar 18, 2024
| <motion.div | ||
| key={bech32IdentityKey(getIdentityKeyFromValueView(delegation))} | ||
| layout | ||
| className='bg-charcoal' |
There was a problem hiding this comment.
Gave it a background so that text doesn't overlap other text during the animations
jessepinho
requested review from
grod220,
turbocrime,
Valentine1898 and
TalDerei
and removed request for
grod220
Valentine1898
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, that was easy.
Screen.Recording.2024-03-18.at.3.41.22.PM.mov
(Note that I had to install
framer-motioninsideminifront. This shouldn't actually add to the bundle size, though, since it's also installed inpackages/ui, which is used byminifront. That said, we could probably save a bit of bundle size by not using framer-motion at all and rolling our own animations, or using the View Transitions API.)