New asset pattern helper #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
force-pushed
the
new-regex-class
branch
from
e7f438f to
b6b4c13
Compare
grod220
commented
Mar 20, 2024
Comment on lines
+109
to
+110
| // eslint-disable-next-line @typescript-eslint/no-confusing-void-expression | ||
| expect(matcher.capture('hello')).toBeUndefined(); |
There was a problem hiding this comment.
Kinda nice the type system knows it shouldn't be calling something without capture groups
grod220
requested review from
jessepinho,
Valentine1898,
TalDerei and
turbocrime
Valentine1898
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposal for new class that assists in typing so we don't have to do the
groups as unknown as GroupTypepattern.