Validate zod only in dev #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
requested review from
jessepinho,
Valentine1898,
TalDerei and
turbocrime
|
doesn't seem to make much difference on my machine chrome-store development |
TalDerei
approved these changes
Mar 20, 2024
|
Yeah, I think the chrome profiler is misattributing to zod. But regardless, I suppose it's best to do this anyway. I believe it's really the json serialization stuff we are seeing there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given we do this on each block save and block sync is performance critical, we should only validate in dev mode. I don't notice a difference (at least on my machine), but still best to do.
See discord for context: https://discord.com/channels/824484045370818580/1044457038886998137/1220036483612807298