Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate tx view in slice #804

Merged
merged 2 commits into from
Mar 20, 2024
Merged

generate tx view in slice #804

merged 2 commits into from
Mar 20, 2024

Conversation

turbocrime
Copy link
Contributor

@turbocrime turbocrime commented Mar 20, 2024

pulled out of work refactoring custody/authorize.

tx view generation tools are now in their own package. we use these tools in the tx approval slice now, and query the view rpc for metadata when necessary, instead of serializing all metadata and posting it with the request message. the slice accesses the fvk directly, meaning the custody rpc no longer requires fvk at all.

@turbocrime turbocrime requested a review from jessepinho March 20, 2024 17:54
Copy link
Contributor

@jessepinho jessepinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! I remember there being some discussion about whether it's OK for the FVK to be in places that are outside of the grpc/custody directory, but I think we decided that's fine as long as it's still in the extension, right? If so, 🚢 it!

@turbocrime turbocrime merged commit 86ea7e3 into main Mar 20, 2024
6 checks passed
@turbocrime turbocrime deleted the turbocrime/tx-view-in-slice branch March 20, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants