Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC page styling changes #808

Closed
wants to merge 7 commits into from
Closed

IBC page styling changes #808

wants to merge 7 commits into from

Conversation

hdevalence
Copy link
Member

I tinkered with the page layout a bit while pairing with @turbocrime on the substantive part (using cosmoskit).

Changes:

  • Puts the IBC page first and calls it Shield Funds. The layout still needs further work, but it conveys a few things:
    • IBC is the first on the list of actions (users can't do anything until they transfer funds...)
    • The cosmos chain UI should be in light theme, while the rest of our UI is in a dark theme, indicating that it is different and has different properties
Screenshot 2024-03-20 at 6 04 04 PM

@grod220 grod220 mentioned this pull request Mar 21, 2024
@hdevalence
Copy link
Member Author

It would be nice to get some version of this merged in so that it doesn't get forgotten, could someone pick it up?

@TalDerei
Copy link
Contributor

It would be nice to get some version of this merged in so that it doesn't get forgotten, could someone pick it up?

think we discussed during web weekly that @turbocrime would pick it up.

@hdevalence
Copy link
Member Author

Awesome!

@turbocrime
Copy link
Contributor

hey, i did pick this up and work on it yesterday/today. sorry for low communication.

i'm working on the 'light' themed card for the ibc page, and implementing the background image in a correct way. our existing widgets make a lot of assumptions and aren't configurable so it's a surprising amount of work. will either finish or upload a wip today

@turbocrime turbocrime force-pushed the penumbra-logo-in-ibc branch from 2de9c91 to 0adfbfe Compare March 26, 2024 23:23
@turbocrime
Copy link
Contributor

#848 #849 #850 #851 #852 and more to achieve responsive layout and styleable components

@grod220
Copy link
Collaborator

grod220 commented Apr 23, 2024

Captured in #850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants