Clarify wasm func naming #833
Conversation
packages/wasm/crate/src/keys.rs
Outdated
| /// Arguments: | ||
| /// full_viewing_key: `bech32 String` | ||
| /// address: `bech32 String` | ||
| /// Returns: `Option<pb::AddressIndex>` | ||
| #[wasm_bindgen] | ||
| pub fn is_controlled_address(full_viewing_key: &str, address: &str) -> WasmResult<JsValue> { | ||
| pub fn get_index_by_address(full_viewing_key: &str, address: &str) -> WasmResult<JsValue> { |
There was a problem hiding this comment.
We pass full_viewing_key and address here as bech32 strings, although we can use the proto types FullViewingKey and Address.
In addition, we manually convert Address to bech32
get_index_by_address(fullViewingKey, bech32Address(address)) as JsonValue;But at the same time, fvk always exists in extension as a bech32 string
I don't think we should fix it in this PR since it doesn't only affect the get_index_by_address function but the whole wasm, but I wonder what you think about it .
There was a problem hiding this comment.
we manually convert Address to bech32
Ah, I should fix this in this PR 👍
fvk always exists in extension as a bech32 string
Indeed, it is a bit strange we pass fvk around as a string versus use the bufbuild type for this. We should definitely update that before mainnet, can you make a ticket for this?
grod220
force-pushed
the
controlled-naming
branch
from
d06562c to
94e7b5e
Compare
grod220
force-pushed
the
controlled-naming
branch
from
94e7b5e to
64a3d89
Compare
Follow up from: https://github.com/penumbra-zone/web/pull/821/files#r1538165300
A small PR to improve the naming of the wasm function getting index from an address.