Update core dependencies to v0.70.3

apps/extension/.env

@@ -1,6 +1,6 @@
 
 PRAX=lkpmkhpnhknhmibgnmmhdhgdilepfghe
-IDB_VERSION=30
+IDB_VERSION=31
 USDC_ASSET_ID="reum7wQmk/owgvGMWMZn/6RFPV24zIKq3W6In/WwZgg="
 MINIFRONT_URL=https://app.testnet.penumbra.zone/
 PENUMBRA_NODE_PD_URL=https://grpc.testnet.penumbra.zone/

apps/minifront/src/state/staking/assemble-undelegate-claim-request.ts

@@ -7,27 +7,28 @@ import {
 import { sctClient, stakeClient, viewClient } from '../../clients';
 import {
   getAmount,
-  getStartEpochIndexFromValueView,
+  getUnbondingStartHeightFromValueView,
   getValidatorIdentityKeyAsBech32StringFromValueView,
 } from '@penumbra-zone/getters/src/value-view';
 import { asIdentityKey } from '@penumbra-zone/getters/src/string';
 
 const getUndelegateClaimPlannerRequest =
   (endEpochIndex: bigint) => async (unbondingToken: ValueView) => {
-    const startEpochIndex = getStartEpochIndexFromValueView(unbondingToken);
+    const unbondingStartHeight = getUnbondingStartHeightFromValueView(unbondingToken);
     const validatorIdentityKeyAsBech32String =
       getValidatorIdentityKeyAsBech32StringFromValueView(unbondingToken);
     const identityKey = asIdentityKey(validatorIdentityKeyAsBech32String);
+    const { epoch: startEpoch } = await sctClient.epochByHeight({ height: unbondingStartHeight });
 
     const { penalty } = await stakeClient.validatorPenalty({
-      startEpochIndex,
+      startEpochIndex: startEpoch?.index,
       endEpochIndex,
       identityKey,
     });
 
     return new TransactionPlannerRequest_UndelegateClaim({
       validatorIdentity: identityKey,
-      startEpochIndex,
+      unbondingStartHeight,
       penalty,
       unbondingAmount: getAmount(unbondingToken),
     });

package.json

@@ -24,8 +24,8 @@
   "dependencies": {
     "@buf/cosmos_ibc.bufbuild_es": "1.8.0-20240327103030-e2006674271c.2",
     "@buf/cosmos_ibc.connectrpc_es": "1.4.0-20240327103030-e2006674271c.2",
-    "@buf/penumbra-zone_penumbra.bufbuild_es": "1.8.0-20240326223351-a25fff24022e.2",
-    "@buf/penumbra-zone_penumbra.connectrpc_es": "1.4.0-20240326223351-a25fff24022e.2",
+    "@buf/penumbra-zone_penumbra.bufbuild_es": "1.8.0-20240327192233-658f3904024e.2",
+    "@buf/penumbra-zone_penumbra.connectrpc_es": "1.4.0-20240327192233-658f3904024e.2",
     "@buf/tendermint_tendermint.bufbuild_es": "1.8.0-20231117195010-33ed361a9051.2",
     "@bufbuild/protobuf": "^1.8.0",
     "@connectrpc/connect": "^1.4.0",

packages/constants/src/assets.test.ts

@@ -40,15 +40,22 @@ describe('assetPatterns', () => {
 
   describe('unbondingTokenPattern', () => {
     it('matches when a string is a valid unbonding token name', () => {
-      expect(assetPatterns.unbondingToken.matches('uunbonding_epoch_1_penumbravalid1abc123')).toBe(
-        true,
+      expect(
+        assetPatterns.unbondingToken.matches('unbonding_start_at_1_penumbravalid1abc123'),
+      ).toBe(true);
+    });
+
+    it('captures the unbonding start height', () => {
+      const match = assetPatterns.unbondingToken.capture(
+        'unbonding_start_at_1_penumbravalid1abc123',
       );
+      expect(match?.startAt).toBe('1');
     });
 
     it('does not match when a string contains, but does not begin with, a valid unbonding token name', () => {
       expect(
         assetPatterns.unbondingToken.matches(
-          'ibc-transfer/channel-1234/uunbonding_epoch_1_penumbravalid1abc123',
+          'ibc-transfer/channel-1234/unbonding_start_at_1_penumbravalid1abc123',
         ),
       ).toBe(false);
     });

packages/constants/src/assets.ts

@@ -22,7 +22,7 @@ export interface DelegationCaptureGroups {
 }
 
 export interface UnbondingCaptureGroups {
-  epoch: string;
+  startAt: string;
   id: string;
   bech32IdentityKey: string;
 }
@@ -73,12 +73,8 @@ export const assetPatterns: AssetPatterns = {
     /^delegation_(?<bech32IdentityKey>penumbravalid1(?<id>[a-zA-HJ-NP-Z0-9]+))$/,
   ),
   proposalNft: new RegexMatcher(/^proposal_/),
-  /**
-   * Unbonding tokens have only one denom unit, which is the base denom. Hence
-   * the extra `u` at the beginning.
-   */
   unbondingToken: new RegexMatcher(
-    /^uunbonding_epoch_(?<epoch>[0-9]+)_(?<bech32IdentityKey>penumbravalid1(?<id>[a-zA-HJ-NP-Z0-9]+))$/,
+    /^unbonding_start_at_(?<startAt>[0-9]+)_(?<bech32IdentityKey>penumbravalid1(?<id>[a-zA-HJ-NP-Z0-9]+))$/,
   ),
   votingReceipt: new RegexMatcher(/^voted_on_/),
   ibc: new RegexMatcher(/^transfer\/(?<channel>channel-\d+)\/(?<denom>.*)/),

packages/getters/src/metadata.test.ts

@@ -2,7 +2,7 @@ import { Metadata } from '@buf/penumbra-zone_penumbra.bufbuild_es/penumbra/core/
 import { describe, expect, it } from 'vitest';
 import {
   getDisplayDenomExponent,
-  getStartEpochIndex,
+  getUnbondingStartHeight,
   getValidatorIdentityKeyAsBech32String,
 } from './metadata';
 
@@ -30,21 +30,21 @@ describe('getDisplayDenomExponent()', () => {
   });
 });
 
-describe('getStartEpochIndex()', () => {
-  it("gets the epoch index, coerced to a `BigInt`, from an unbonding token's asset ID", () => {
-    const metadata = new Metadata({ display: 'uunbonding_epoch_123_penumbravalid1abc123' });
+describe('getUnbondingStartHeight()', () => {
+  it("gets the unbonding start height, coerced to a `BigInt`, from an unbonding token's asset ID", () => {
+    const metadata = new Metadata({ display: 'unbonding_start_at_123_penumbravalid1abc123' });
 
-    expect(getStartEpochIndex(metadata)).toBe(123n);
+    expect(getUnbondingStartHeight(metadata)).toBe(123n);
   });
 
   it("returns `undefined` for a non-unbonding token's metadata", () => {
     const metadata = new Metadata({ display: 'penumbra' });
 
-    expect(getStartEpochIndex.optional()(metadata)).toBeUndefined();
+    expect(getUnbondingStartHeight.optional()(metadata)).toBeUndefined();
   });
 
   it('returns `undefined` for undefined metadata', () => {
-    expect(getStartEpochIndex.optional()(undefined)).toBeUndefined();
+    expect(getUnbondingStartHeight.optional()(undefined)).toBeUndefined();
   });
 });
 
@@ -58,7 +58,7 @@ describe('getValidatorIdentityKeyAsBech32String()', () => {
   });
 
   describe('when passed metadata of an unbonding token', () => {
-    const metadata = new Metadata({ display: 'uunbonding_epoch_123_penumbravalid1abc123' });
+    const metadata = new Metadata({ display: 'unbonding_start_at_123_penumbravalid1abc123' });
 
     it("returns the bech32 representation of the validator's identity key", () => {
       expect(getValidatorIdentityKeyAsBech32String(metadata)).toBe('penumbravalid1abc123');

packages/getters/src/metadata.ts

@@ -23,19 +23,19 @@ export const getDisplayDenomExponent = createGetter(
 );
 
 /**
- * Get the start epoch index from the metadata of an unbonding token -- that is,
- * the epoch at which unbonding started.
+ * Get the unbonding start height index from the metadata of an unbonding token
+ * -- that is, the block height at which unbonding started.
  *
  * For metadata of a non-unbonding token, will return `undefined`.
  */
-export const getStartEpochIndex = createGetter((metadata?: Metadata) => {
+export const getUnbondingStartHeight = createGetter((metadata?: Metadata) => {
   if (!metadata) return undefined;
 
   const unbondingMatch = assetPatterns.unbondingToken.capture(metadata.display);
 
   if (unbondingMatch) {
-    const { epoch } = unbondingMatch;
-    if (epoch) return BigInt(epoch);
+    const { startAt } = unbondingMatch;
+    return BigInt(startAt);
   }
 
   return undefined;

packages/getters/src/undelegate-claim.ts

@@ -9,10 +9,12 @@ export const getBody = createGetter((undelegateClaim?: UndelegateClaim) => undel
 
 export const getValidatorIdentityFromUndelegateClaim = getBody.pipe(getValidatorIdentity);
 
-export const getStartEpochIndexFromUndelegateClaim = getBody.pipe(
-  // Defining this inline rather than exporting `getStartEpochIndex` from
-  // `undelegate-claim-body.ts`, since `getStartEpochIndex` is already defined
-  // elsewhere and thus would result in a naming conflict in the exports from
-  // this package.
-  createGetter((undelegateClaimBody?: UndelegateClaimBody) => undelegateClaimBody?.startEpochIndex),
+export const getUnbondingStartHeightFromUndelegateClaim = getBody.pipe(
+  // Defining this inline rather than exporting `getUnbondingStartHeight` from
+  // `undelegate-claim-body.ts`, since `getUnbondingStartHeight` is already
+  // defined elsewhere and thus would result in a naming conflict in the exports
+  // from this package.
+  createGetter(
+    (undelegateClaimBody?: UndelegateClaimBody) => undelegateClaimBody?.unbondingStartHeight,
+  ),
 );

packages/getters/src/value-view.ts

@@ -3,7 +3,7 @@ import { createGetter } from './utils/create-getter';
 import { bech32AssetId } from '@penumbra-zone/bech32/src/asset';
 import {
   getDisplayDenomExponent,
-  getStartEpochIndex,
+  getUnbondingStartHeight,
   getValidatorIdentityKeyAsBech32String,
 } from './metadata';
 import { Any } from '@bufbuild/protobuf';
@@ -72,9 +72,10 @@ export const getAmount = createGetter(
 );
 
 /**
- * For a `ValueView` containing an unbonding token, gets the start epoch index.
+ * For a `ValueView` containing an unbonding token, gets the unbonding start
+ * height.
  */
-export const getStartEpochIndexFromValueView = getMetadata.pipe(getStartEpochIndex);
+export const getUnbondingStartHeightFromValueView = getMetadata.pipe(getUnbondingStartHeight);
 
 export const getDisplayDenomFromView = createGetter((view?: ValueView) => {
   if (view?.valueView.case === 'unknownAssetId') {

packages/query/src/block-processor.ts

@@ -145,13 +145,18 @@ export class BlockProcessor implements BlockProcessorInterface {
     const startHeight = fullSyncHeight ? fullSyncHeight + 1n : 0n;
     let latestKnownBlockHeight = await this.querier.tendermint.latestBlockHeight();
 
-    // In the `for` loop below, we only update validator infos once we've
-    // reached the latest known epoch. This means that, if a user is syncing for
-    // the first time, they could experience a broken UI until the latest known
-    // epoch is reached, since they may have delegation tokens but no validator
-    // info to go with them. So we'll update validator infos at the beginning of
-    // sync as well, and force the rest of sync to wait until it's done.
-    if (startHeight === 0n) await this.updateValidatorInfos(0n);
+    if (startHeight === 0n) {
+      // In the `for` loop below, we only update validator infos once we've
+      // reached the latest known epoch. This means that, if a user is syncing
+      // for the first time, they could experience a broken UI until the latest
+      // known epoch is reached, since they may have delegation tokens but no
+      // validator info to go with them. So we'll update validator infos at the
+      // beginning of sync as well, and force the rest of sync to wait until
+      // it's done.
+      await this.updateValidatorInfos(0n);
+
+      await this.indexedDb.addEpoch(0n);
+    }
 
     // this is an indefinite stream of the (compact) chain from the network
     // intended to run continuously
@@ -273,7 +278,7 @@ export class BlockProcessor implements BlockProcessorInterface {
 
       const isLastBlockOfEpoch = !!compactBlock.epochRoot;
       if (isLastBlockOfEpoch) {
-        void this.handleEpochTransition(compactBlock.height, latestKnownBlockHeight);
+        await this.handleEpochTransition(compactBlock.height, latestKnownBlockHeight);
       }
     }
   }

packages/router/src/grpc/view-protocol-server/asset-metadata-by-id.test.ts

@@ -75,10 +75,11 @@ describe('AssetMetadataById request handler', () => {
     expect(metadataByIdResponse.denomMetadata?.equals(metadataFromNode)).toBeTruthy();
   });
 
-  test('should fail to get metadata when metadata not found in idb and node', async () => {
+  test('should return an empty response when metadata not found in idb and node', async () => {
     mockIndexedDb.getAssetsMetadata?.mockResolvedValue(undefined);
     mockShieldedPool.assetMetadataById.mockResolvedValueOnce(undefined);
-    await expect(assetMetadataById(request, mockCtx)).rejects.toThrow();
+    const response = new AssetMetadataByIdResponse(await assetMetadataById(request, mockCtx));
+    expect(response.equals(new AssetMetadataByIdResponse())).toBeTruthy();
   });
 
   test('should fail if assetId is missing in request', async () => {

packages/router/src/grpc/view-protocol-server/helpers.ts

@@ -25,6 +25,5 @@ export const getAssetMetadata = async (
     return nodeMetadata;
   }
 
-  // If the metadata is not found, throw an error with details about the asset.
-  throw new Error(`No denom metadata found for asset: ${JSON.stringify(targetAsset.toJson())}`);
+  return undefined;
 };

packages/storage/src/indexed-db/index.ts

@@ -458,12 +458,14 @@ export class IndexedDb implements IndexedDbInterface {
     });
   }
 
-  async addEpoch(startHeight: bigint, index?: bigint): Promise<void> {
-    if (index === undefined) {
-      const cursor = await this.db.transaction('EPOCHS', 'readonly').store.openCursor(null, 'prev');
-      const previousEpoch = cursor?.value ? Epoch.fromJson(cursor.value) : undefined;
-      index = previousEpoch?.index !== undefined ? previousEpoch.index + 1n : 0n;
-    }
+  /**
+   * Adds a new epoch with the given start height. Automatically sets the epoch
+   * index by finding the previous epoch index, and adding 1n.
+   */
+  async addEpoch(startHeight: bigint): Promise<void> {
+    const cursor = await this.db.transaction('EPOCHS', 'readonly').store.openCursor(null, 'prev');
+    const previousEpoch = cursor?.value ? Epoch.fromJson(cursor.value) : undefined;
+    const index = previousEpoch?.index !== undefined ? previousEpoch.index + 1n : 0n;
 
     const newEpoch = {
       startHeight: startHeight.toString(),

packages/types/src/customize-symbol.test.ts

@@ -15,10 +15,10 @@ describe('Customizing metadata', () => {
   test('should work for unbonding token', () => {
     const metadata = new Metadata({
       display:
-        'uunbonding_epoch_29_penumbravalid1fjuj67ayaqueqxg03d65ps5aah6m39u39qeacu3zv2cw3dzxssyq3yrcez',
+        'unbonding_start_at_29_penumbravalid1fjuj67ayaqueqxg03d65ps5aah6m39u39qeacu3zv2cw3dzxssyq3yrcez',
     });
 
-    expect(customizeSymbol(metadata).symbol).toBe('unbondUMe29(fjuj67ay…)');
+    expect(customizeSymbol(metadata).symbol).toBe('unbondUMat29(fjuj67ay…)');
   });
 
   test('should do nothing if no matches', () => {

packages/types/src/customize-symbol.ts

@@ -18,7 +18,7 @@ export const customizeSymbol = (metadata: Metadata) => {
   if (unbondingMatch) {
     const shortenedId = unbondingMatch.id.slice(0, SHORTENED_ID_LENGTH);
     const customized = metadata.clone();
-    customized.symbol = `unbondUMe${unbondingMatch.epoch}(${shortenedId}…)`;
+    customized.symbol = `unbondUMat${unbondingMatch.startAt}(${shortenedId}…)`;
     return customized;
   }
 

packages/types/src/indexed-db.ts

@@ -89,7 +89,7 @@ export interface IndexedDbInterface {
   ): AsyncGenerator<PositionId, void>;
   addPosition(positionId: PositionId, position: Position): Promise<void>;
   updatePosition(positionId: PositionId, newState: PositionState): Promise<void>;
-  addEpoch(startHeight: bigint, index?: bigint): Promise<void>;
+  addEpoch(startHeight: bigint): Promise<void>;
   getEpochByHeight(height: bigint): Promise<Epoch | undefined>;
   upsertValidatorInfo(validatorInfo: ValidatorInfo): Promise<void>;
   iterateValidatorInfos(): AsyncGenerator<ValidatorInfo, void>;

packages/ui/components/ui/tx/view/undelegate-claim.tsx

@@ -3,14 +3,14 @@ import { ViewBox } from './viewbox';
 import { IdentityKeyComponent } from '../../identity-key-component';
 import { ActionDetails } from './action-details';
 import {
-  getStartEpochIndexFromUndelegateClaim,
+  getUnbondingStartHeightFromUndelegateClaim,
   getValidatorIdentityFromUndelegateClaim,
 } from '@penumbra-zone/getters/src/undelegate-claim';
 
 /** Render an `UndelegateClaim` action. */
 export const UndelegateClaimComponent = ({ value }: { value: UndelegateClaim }) => {
   const validatorIdentity = getValidatorIdentityFromUndelegateClaim(value);
-  const startEpochIndex = getStartEpochIndexFromUndelegateClaim(value);
+  const unbondingStartHeight = getUnbondingStartHeightFromUndelegateClaim(value);
 
   return (
     <ViewBox
@@ -21,8 +21,8 @@ export const UndelegateClaimComponent = ({ value }: { value: UndelegateClaim })
             <IdentityKeyComponent identityKey={validatorIdentity} />
           </ActionDetails.Row>
 
-          <ActionDetails.Row label='Unbonding start epoch'>
-            {startEpochIndex.toString()}
+          <ActionDetails.Row label='Unbonding start height'>
+            {unbondingStartHeight.toString()}
           </ActionDetails.Row>
         </ActionDetails>
       }

packages/ui/components/ui/tx/view/undelegate.tsx

@@ -13,10 +13,6 @@ export const UndelegateComponent = ({ value }: { value: Undelegate }) => {
       label='Undelegate'
       visibleContent={
         <ActionDetails>
-          <ActionDetails.Row label='Epoch index'>
-            {value.startEpochIndex.toString()}
-          </ActionDetails.Row>
-
           {!!value.delegationAmount && (
             <ActionDetails.Row label='Delegation amount'>
               {joinLoHiAmount(value.delegationAmount).toString()}

packages/ui/components/ui/tx/view/value/index.tsx

@@ -33,7 +33,7 @@ export const ValueViewComponent = ({
     const value = view.valueView.value;
     const metadata = view.valueView.value.metadata;
     const amount = value.amount ?? new Amount();
-    const exponent = getDisplayDenomExponent(metadata);
+    const exponent = getDisplayDenomExponent.optional()(metadata);
     // The regex trims trailing zeros which toFormat adds in
     const formattedAmount = fromBaseUnitAmount(amount, exponent)
       .toFormat(6)