-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ViewService#unbondingTokensByAddressIndex
; update to v0.71.0
#862
Merged
jessepinho
merged 18 commits into
main
from
jessepinho/unbonding-token-eligibiltiy-web-739
Apr 2, 2024
Merged
Implement ViewService#unbondingTokensByAddressIndex
; update to v0.71.0
#862
jessepinho
merged 18 commits into
main
from
jessepinho/unbonding-token-eligibiltiy-web-739
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepinho
force-pushed
the
jessepinho/unbonding-token-eligibiltiy-web-739
branch
from
March 30, 2024 23:47
38696af
to
41e4ec4
Compare
jessepinho
force-pushed
the
jessepinho/unbonding-token-eligibiltiy-web-739
branch
from
March 31, 2024 00:54
9023886
to
af2781d
Compare
jessepinho
changed the title
WIP: Split unbonding tokens into claimable and not-yet-claimable sections
WIP: Split unbonding tokens into claimable and not-yet-claimable sections; update to v0.71.0
Mar 31, 2024
jessepinho
changed the title
WIP: Split unbonding tokens into claimable and not-yet-claimable sections; update to v0.71.0
Implement Mar 31, 2024
ViewService#unbondingTokensByAddressIndex
; update to v0.71.0
grod220
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Comment on lines
+19
to
+20
// See https://github.com/typescript-eslint/typescript-eslint/issues/7114 | ||
// eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should disable this rule globally with this comment until the bug is fixed
…863) * Start displaying unbonding vs claimable sections * Use different help text for each * Refresh unbonding tokens after an undelegate or undelegate claim * Fix tests * Fix account switcher filter * Use a shallow selector for StakingLayout * Remove unused getter * Extract a ZERO_BALANCE_UM const * Clean up code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Most line changes are lockfiles and tests
This is the first part of #739 — creating an implementation of
ViewService#unbondingTokensByAddressIndex
that will, in my next PR, be used to show claimable vs not-yet-claimable unbonding tokens on the staking page.In this PR
ViewService#unbondingTokensByAddressIndex
implRelates to #739