Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ViewService#unbondingTokensByAddressIndex; update to v0.71.0 #862

Merged
merged 18 commits into from
Apr 2, 2024

Conversation

jessepinho
Copy link
Contributor

@jessepinho jessepinho commented Mar 30, 2024

🚨 Most line changes are lockfiles and tests

This is the first part of #739 — creating an implementation of ViewService#unbondingTokensByAddressIndex that will, in my next PR, be used to show claimable vs not-yet-claimable unbonding tokens on the staking page.

In this PR

  • Update to v0.71.0 of core
  • Create ViewService#unbondingTokensByAddressIndex impl

Relates to #739

@jessepinho jessepinho force-pushed the jessepinho/unbonding-token-eligibiltiy-web-739 branch from 38696af to 41e4ec4 Compare March 30, 2024 23:47
@jessepinho jessepinho force-pushed the jessepinho/unbonding-token-eligibiltiy-web-739 branch from 9023886 to af2781d Compare March 31, 2024 00:54
@jessepinho jessepinho changed the title WIP: Split unbonding tokens into claimable and not-yet-claimable sections WIP: Split unbonding tokens into claimable and not-yet-claimable sections; update to v0.71.0 Mar 31, 2024
@jessepinho jessepinho changed the title WIP: Split unbonding tokens into claimable and not-yet-claimable sections; update to v0.71.0 Implement ViewService#unbondingTokensByAddressIndex; update to v0.71.0 Mar 31, 2024
@jessepinho jessepinho marked this pull request as ready for review March 31, 2024 02:13
Copy link
Collaborator

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +19 to +20
// See https://github.com/typescript-eslint/typescript-eslint/issues/7114
// eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should disable this rule globally with this comment until the bug is fixed

…863)

* Start displaying unbonding vs claimable sections

* Use different help text for each

* Refresh unbonding tokens after an undelegate or undelegate claim

* Fix tests

* Fix account switcher filter

* Use a shallow selector for StakingLayout

* Remove unused getter

* Extract a ZERO_BALANCE_UM const

* Clean up code
@jessepinho jessepinho merged commit 2b5fa1a into main Apr 2, 2024
6 checks passed
@jessepinho jessepinho deleted the jessepinho/unbonding-token-eligibiltiy-web-739 branch April 2, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants