Check for an existing start epoch before creating one #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug we had before where, for some reason (probably related to exponential back-off), the start epoch with index 0 was being saved multiple times. This threw off the count for epochs, making delegate actions fail (since they use epoch indexes).
jessepinho
commented
Mar 31, 2024
| @@ -1,6 +1,6 @@ | |||
|
|
|||
| PRAX=lkpmkhpnhknhmibgnmmhdhgdilepfghe | |||
| IDB_VERSION=31 | |||
| IDB_VERSION=32 | |||
There was a problem hiding this comment.
Anyone who has duplicate epochs in their database already will need to regenerate their data from scratch — hence the version bump.
|
LGTM. I'm not seeing any duplicate nullifiers in indexDB, but what does different epochs with the same 
|
TalDerei
approved these changes
Apr 1, 2024
|
@TalDerei different epochs with the same start height is a duplicate epoch — it means we saved more than one epoch (with different indexes) at the same start height. And yeah, I think it's due to a sync delay. We use a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug we had before where, for some reason (probably related to exponential back-off), the start epoch with index 0 was being saved multiple times. This threw off the count for epochs, making delegate actions fail (since they use epoch indexes). To fix this, we create epoch 0 outside of the syncAndStore method, at DB initialization.
Closes #865