Add console checks for sct divergence #882
Conversation
| @@ -141,7 +148,7 @@ export class BlockProcessor implements BlockProcessorInterface { | |||
|
|
|||
| private async syncAndStore() { | |||
| const fullSyncHeight = await this.indexedDb.getFullSyncHeight(); | |||
| const startHeight = fullSyncHeight ? fullSyncHeight + 1n : 0n; | |||
| const startHeight = fullSyncHeight !== undefined ? fullSyncHeight + 1n : 0n; // Must compare to undefined as 0n is falsy | |||
There was a problem hiding this comment.
Found an interesting bug. After we sync block 0, we save full sync height as 0. However, 0 is a falsy value. That means if the block processor was reset between blocks 0 and 1000, we'd have a sct root divergence.
There was a problem hiding this comment.
Nice catch 👍
I wonder if this fixes the divergence that occurs on Henry's wallet (I suspect Henry didn't stop synchronization specifically between the 0 and 1000 block)
There was a problem hiding this comment.
Hmm, I did make transactions in the first 1000 blocks, so if it paused to fetch full tx details, that could have been an opportunity for interruption...
grod220
requested review from
jessepinho,
Valentine1898,
TalDerei and
turbocrime
| declare global { | ||
| // `var` required for global declaration (as let/const are block scoped) | ||
| // eslint-disable-next-line no-var | ||
| var ASSERT_ROOT_VALID: boolean | undefined; | ||
| } |
There was a problem hiding this comment.
@grod220 can we get some docs in the dev docs about the existence of this global and how you would set it and why?
Closes #878
vid_compressed.mp4