Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show equivalent values in the assets table #886

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Show equivalent values in the assets table #886

merged 3 commits into from
Apr 5, 2024

Conversation

jessepinho
Copy link
Contributor

Pretty straightforward. I also added a tooltip for equivalent values to make it clear what they represent:

image

@jessepinho jessepinho marked this pull request as ready for review April 4, 2024 22:20
grod220
grod220 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design-wise, I do wonder if we should bring back the table layout:

Asset Equivalent Values
10um 332.2usdc
53uxyz 66um, 324234usdc

@jessepinho
Copy link
Contributor Author

@grod220 I'll merge this and do a quick spike on making it use a table

@jessepinho jessepinho merged commit acd9d1e into main Apr 5, 2024
6 checks passed
@jessepinho jessepinho deleted the jessepinho/show-equivalent-values-web-529 branch April 5, 2024 18:53
@jessepinho jessepinho mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalDerei TalDerei TalDerei approved these changes

@grod220 grod220 grod220 approved these changes

@Valentine1898 Valentine1898 Awaiting requested review from Valentine1898

@turbocrime turbocrime Awaiting requested review from turbocrime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessepinho @grod220 @TalDerei