Create issue template for deployments #888
Conversation
jessepinho
changed the title
.github/ISSUE_TEMPLATE/deployment.md
Outdated
| - [ ] Staking | ||
| - [ ] IBC | ||
| - [ ] Tx details | ||
| - [x] ~Do a full sync with with [assertRootValid()](https://github.com/penumbra-zone/web/blob/main/packages/query/src/block-processor.ts#L383-L395) enabled. Will throw if TCT roots are not correct.~ (Ignore for now.) |
There was a problem hiding this comment.
I'd change this to:
- [ ] Test sync with [assertRootValid()](https://github.com/penumbra-zone/web/blob/992bc2d975ef55537dac95db4e29c49715bf740b/docs/debugging.md) enabled. Will throw if TCT roots are not correct.Don't think we need to do a full sync (as this would take forever)
There was a problem hiding this comment.
OK, got it. Are we no longer ignoring this, then?
There was a problem hiding this comment.
Yes, think we good to add this
.github/ISSUE_TEMPLATE/deployment.md
Outdated
| - [ ] Run `pnpm build` in the web repo's root. Then take minifront & node-status `dist` output and make PR against core repo to update node's frontends. | ||
| - [ ] Wait 1-3 days until new extension version is live on [chrome web store](https://chromewebstore.google.com/detail/penumbra-wallet/lkpmkhpnhknhmibgnmmhdhgdilepfghe) | ||
| - [ ] Run `Deploy Static Site` [github action](https://github.com/penumbra-zone/web/actions/workflows/deploy-firebase-dapp.yml) | ||
| - [ ] Make `@channel` announcement in Discord #web-ext-feedback channel if there are any relevant features to announce. |
There was a problem hiding this comment.
We really haven't nailed down what the comms strategy is. Maybe we should put:
- [ ] Work with comms team for relevant discord announcements and social posts for new features we want to amplify
There was a problem hiding this comment.
I feel like this could be out of scope for Github planning and something to revisit post repo-disentangling
There was a problem hiding this comment.
All the stuff related to the extension will be migrated. And in the new repo, these deployment docs are still relevant.
There was a problem hiding this comment.
We'll just need to amend a few lines and file locations. But think it's best not to lose this work waiting on the migration.
There was a problem hiding this comment.
Sounds good, to clarify my comment was along the lines of "here's reasons why this can be imperfect now" rather than "we should not do this at all"
|
oooo PR 888 nice |
Previously, the deployment docs pointed to a link that had the issue template embedded in the query string, which made it hard to update. This PR extracts that template to an issue template markdown file, and updates the link. Note that this can only really be tested once it's merged, since the link in the deployment docs points to a template that won't exist until this is merged.