Stream transactions in transactions table to avoid blocking loading #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepinho
requested review from
turbocrime,
grod220,
Valentine1898 and
TalDerei
turbocrime
approved these changes
Apr 13, 2024
grod220
reviewed
Apr 15, 2024
Comment on lines
+17
to
+41
| export const createTransactionsSlice = (): SliceCreator<TransactionsSlice> => (set, get) => ({ | ||
| summaries: [], | ||
|
|
||
| loadSummaries: async () => { | ||
| set(state => { | ||
| state.transactions.summaries = []; | ||
| }); | ||
|
|
||
| for await (const tx of viewClient.transactionInfo({})) { | ||
| const summary = { | ||
| height: Number(tx.txInfo?.height ?? 0n), | ||
| hash: tx.txInfo?.id?.inner ? uint8ArrayToHex(tx.txInfo.id.inner) : 'unknown', | ||
| description: getTransactionClassificationLabel(tx.txInfo?.view), | ||
| }; | ||
|
|
||
| const summaries = [...get().transactions.summaries, summary].sort( | ||
| (a, b) => b.height - a.height, | ||
| ); | ||
|
|
||
| set(state => { | ||
| state.transactions.summaries = summaries; | ||
| }); | ||
| } | ||
| }, | ||
| }); |
There was a problem hiding this comment.
I wonder if this is better than using useStream? 🤔
useStream feels more generic and we could make it accept a transformer or create our own custom hook that wraps around that. Not sure, what do you think?
There was a problem hiding this comment.
Yeah, I'd considered that. The only reason I didn't is that I assumed we'd want this data in Zustand state. But, it could go either way 🤷🏻♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-04-12.at.8.40.11.PM.mov
Reviewers, what do you think of this?
@Valentine1898 pointed out in #911 that there's a delay when switching to the transactions table if you have a lot of transactions. So in this PR, I switched it to stream results, so that it's more responsive.
This results in a similar issue to what we were dealing with on the staking page, though: the page might actually take longer to load all the data, even though it feels faster, because of rendering costs.
That said, I generated nearly 200 transactions and then loaded the page, and it finished loading in under a second. So I think we're OK.
Closes #911