Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't assert key #953

Merged
merged 1 commit into from
Apr 18, 2024
Merged

don't assert key #953

merged 1 commit into from
Apr 18, 2024

Conversation

turbocrime
Copy link
Contributor

@turbocrime turbocrime commented Apr 18, 2024 •
edited
Loading

fixes undefined access (might not have a key url, if action needs no key)

@turbocrime turbocrime requested a review from grod220 April 18, 2024 16:27
@turbocrime turbocrime self-assigned this Apr 18, 2024
@TalDerei
Copy link
Contributor

nice catch

@turbocrime turbocrime merged commit 7289840 into main Apr 18, 2024
6 checks passed
@turbocrime turbocrime deleted the turbocrime/dont-assert-key branch April 18, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalDerei TalDerei TalDerei approved these changes

@grod220 grod220 Awaiting requested review from grod220

@jessepinho jessepinho Awaiting requested review from jessepinho

@Valentine1898 Valentine1898 Awaiting requested review from Valentine1898

Assignees

@turbocrime turbocrime

Labels
None yet
Projects
Penumbra web
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbocrime @TalDerei