@penumbra-zone/wasm
#955
Merged
@penumbra-zone/wasm
#955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah, wasm-pack creates a gitignore |
turbocrime
changed the title
@penumbra-zone/keys and @penumbra-zone/wasm
Merged
turbocrime
force-pushed
the
turbocrime/wasm-package
branch
from
2516169 to
a48b39b
Compare
turbocrime
changed the title
@penumbra-zone/keys and @penumbra-zone/wasm@penumbra-zone/wasm
turbocrime
force-pushed
the
turbocrime/wasm-package
branch
from
a48b39b to
49da696
Compare
grod220
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Nice job! After this is merged, the bot will update this PR: #940. Then if you merge that, this will publish to npm for the consumer needing this.
Also, could you add documentation to a README.md on how to use this package? Think it would be helpful to give instructions on:
- No keys usage
- Usage w/ keys (and downloading that optional package)
- Possible required webpack/next configs
TalDerei
approved these changes
Apr 19, 2024
turbocrime
force-pushed
the
turbocrime/wasm-package
branch
from
49da696 to
745ee92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work on #737
the wasm package on npm is outdated, and we have consumers trying to use, so i took a shot at this
keys package
@penumbra-zone/keys#958wasm package
verified working on an example nextjs app with the output of
pnpm packwhich you can view at https://github.com/turbocrime/nextjs-penumbra-wasm-example/