Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with shifting account header #976

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

jessepinho
Copy link
Contributor

@jessepinho jessepinho commented Apr 23, 2024

From #966:

Toggling between account 0 and 1 makes the title hop a bit left and right. Likely due to arrow not being there for padding.

Screen.Recording.2024-04-19.at.3.55.05.PM.mov

Now, the next/previous buttons are always showing, but are disabled if we're on the last/first account, respectively:
image

Closes #966

@jessepinho jessepinho marked this pull request as ready for review April 24, 2024 00:01
Copy link
Contributor

@TalDerei TalDerei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessepinho jessepinho merged commit e512bd1 into main Apr 24, 2024
6 checks passed
@jessepinho jessepinho deleted the jessepinho/account-switcher-moving branch April 24, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account switcher heading movement
3 participants