bech32m

[turbocrime]

fixing #778 and providing typesafe, named functions

also updating most of the tests to use more realistic data, now that lengths and checksums are validated everywhere.

this package is configured to build with tsc for publish, despite discussion of not building - it's a relatively simple package, the main export is all constant primitives, and it may be used in simpler contexts than the larger and more complex packages that depend on message types.

the diff is huge, because these functions are used absolutely everywhere.

[grod220]

Nice tests!

[turbocrime]

tests for removed function deleted

[turbocrime]

use replaced with getValidatorIdentityKey plus bech32IdentityKey

[grod220]

We should avoid using default exports in general

[grod220]

Same here, let's name our exports

[grod220]

This package seems to have multiple ways its accessing the same information

A)
import { Prefixes } from './format/prefix';
const prefix = Prefixes.passet;

B)
import SPEC from './format';
export const PENUMBRA_BECH32M_ASSETID_PREFIX = SPEC.passet.prefix;

Instead of defining all of these parameters in separate objects, it feels simpler to just put them all in this file. Aka, this:

export const bech32Spec = {
  passet: {
    prefix: 'passet',
    stringLength: 65,
    byteLength: 32,
    innerName: "inner",
  },
}

versus

import { Inner } from './inner';
import { StringLength } from './strings';
import { ByteLength } from './bytes';
import { Prefixes } from './prefix';

export const bech32Spec = {
  passet: {
    prefix: Prefixes.passet,
    stringLength: StringLength.passet,
    byteLength: ByteLength.passet,
    innerName: Inner.passet,

This will allow us also to delete packages/bech32m/src/index.ts entirely

[grod220]

The whole purpose of this package is to allow us easy ways to convert to/from bech32 to/from Penumbra protobuf types. Returning approximations of the inside of these types feels unnecessary, especially given all consumers will then be required to construct the type manually right after. The more natural API is to simply return what they need. I think we should do this:

- export const assetIdFromBech32m = (passet1: string): { [innerName]: Uint8Array }
+ export const assetIdFromBech32m = (passet1: string): AssetId

[turbocrime]

the whole purpose of the package is to verify bech32m or convert from bech32m to binary data in a verifiable way.

the types are a convenience. i would prefer to remove the structure than to add the types.

[grod220]

Talked offline. Can revisit these topics later.