faster dev init, fix wasm clean #985
Conversation
turbocrime
force-pushed
the
turbocrime/faster-dev
branch
from
0feed79 to
632074f
Compare
turbocrime
force-pushed
the
turbocrime/faster-dev
branch
from
632074f to
cc14a83
Compare
|
threw in a couple script tweaks |
turbocrime
force-pushed
the
turbocrime/faster-dev
branch
from
6631eac to
edf0479
Compare
| @@ -5,7 +5,7 @@ node_modules | |||
|
|
|||
| # testing | |||
| coverage | |||
| vite.config.ts.timestamp-*-*.mjs | |||
| vite*.config.ts.timestamp-*-*.mjs | |||
There was a problem hiding this comment.
this was missing a vitest.config.ts.timestamp...
| @@ -8,7 +8,7 @@ | |||
| "all-check": "pnpm clean && pnpm install && pnpm compile && pnpm lint && pnpm lint:rust && pnpm build && pnpm test && pnpm test:rust", | |||
| "build": "turbo build", | |||
| "clean": "turbo clean", | |||
| "clean:vitest-mjs": "find . -type f -name 'vite.config.ts.timestamp-*-*.mjs' -ls -delete", | |||
| "clean:vitest-mjs": "find . -type f -name 'vite*.config.ts.timestamp-*-*.mjs' -ls -delete", | |||
| @@ -4,11 +4,11 @@ | |||
| "license": "(MIT OR Apache-2.0)", | |||
| "type": "module", | |||
| "scripts": { | |||
| "clean": "rm -v wasm/index*", | |||
| "clean": "rm -fv wasm/index*", | |||
There was a problem hiding this comment.
prevents failing if this is already clean
| "clean:rust": "cargo clean --manifest-path ./crate/Cargo.toml", | ||
| "compile": "cd crate && wasm-pack build --no-pack --target bundler --out-name index --out-dir ../wasm", | ||
| "dev": "cargo watch -C ./crate --postpone -- pnpm turbo run compile", | ||
| "format": "cd crate && cargo fmt --all", | ||
| "format:rust": "cd crate && cargo fmt --all", |
There was a problem hiding this comment.
this was already present in turbo.json but not used. now named as intended
| "format": { | ||
| "cache": false, | ||
| "dependsOn": ["//#format:syncpack", "//#format:prettier", "format:rust"] | ||
| "dependsOn": ["format:ts", "format:rust"] | ||
| }, | ||
| "format:rust": { | ||
| "dependsOn": ["compile"], | ||
| "inputs": ["crate/src/**", "crate/Cargo.toml", "crate/Cargo.lock", "crate/tests/**"] | ||
| "cache": false | ||
| }, | ||
| "format:ts": { | ||
| "cache": false, | ||
| "dependsOn": ["//#format:syncpack", "//#format:prettier"] |
There was a problem hiding this comment.
allow option to only format typescript, as format rust has rust dependency. typical use of format command remains the same
| "dev": { | ||
| "cache": false, | ||
| "dependsOn": ["build"], | ||
| "dependsOn": ["^compile"], | ||
| "persistent": true | ||
| }, |
There was a problem hiding this comment.
dev requires compile of dependencies, and vite will dynamically build all the typescript, so we don't need to depend on build. depending on build only adds a startup delay and demands a perfect build, instead of allowing warnings like dev. so this change allows faster development.
full build requirements are still present in all-check and are enforced by ci, so we lose nothing.
|
oh hmm i think the build issues are not solved. i am working on it now |
turbocrime
force-pushed
the
turbocrime/all-package-exports
branch
from
b2ebdda to
c082712
Compare
|
this needs to wait for #995 |
jesse complained about dev startup slowing down so changing dep from build to compile should accelerate it.
i believe the build issues (package exports) present in 4ef2ef7 that prompted this change are by #995, so there should be no negative effects of this, but watch out for broken HMR or other issues