add presets to ContextFormSerializer #176
Conversation
| @@ -4,6 +4,7 @@ RenderContextSerializer.test_queryset: | |||
| - db: SELECT ... FROM "formidable_item" WHERE "formidable_item"."field_id" IN (...) ORDER BY "formidable_item"."order" ASC | |||
| - db: SELECT ... FROM "formidable_validation" WHERE "formidable_validation"."field_id" IN (...) | |||
| - db: SELECT ... FROM "formidable_default" WHERE "formidable_default"."field_id" IN (...) | |||
| - db: 'SELECT ... FROM "formidable_preset" WHERE "formidable_preset"."form_id" = #' | |||
There was a problem hiding this comment.
it adds a SQL query. I'd be glad to have it retrieved using a "select_related" queryset
There was a problem hiding this comment.
select_related will not work. It's a prefetch_related we want to have ,and the prefetch will actually generate one more queries.
But @brunobord is right, if you actually have more than one presets , multiple queries will be generated.
There was a problem hiding this comment.
do you mean I should prefetch preset arguments ?
demo/tests/test_end_point.py
Outdated
|
|
||
| preset1 = form.presets.create(slug='foo', message='message1') | ||
| preset1.arguments.create(slug='arg_field', field_id='field_A') | ||
| preset1.arguments.create(slug='arg_value', value='42') |
There was a problem hiding this comment.
OMG We can create a presets argument linked to nothing.... Seems more important to resolve this issue
demo/tests/test_end_point.py
Outdated
|
|
||
| form = Formidable.objects.create(label='my_test_form') | ||
|
|
||
| preset1 = form.presets.create(slug='foo', message='message1') |
There was a problem hiding this comment.
And we can create a presets we actually is not implemented....
There was a problem hiding this comment.
Actually, I expect to have a presets which actually working in order to avoid future explosion when we will add check on existing Presets (Hell yeah, I'm confident !)
Please create a comparison Presets with three arguments,
The field argument, with its little name "left" , the operator argument with its little name, "operator" and the last one but not least the value you want to compare.
demo/tests/test_end_point.py
Outdated
| @@ -328,6 +328,62 @@ class TestForm(FormidableForm): | |||
| with django_perf_rec.record(path='perfs/'): | |||
| serializer.data | |||
|
|
|||
| def test_presets(self): | |||
|
|
|||
| form = Formidable.objects.create(label='my_test_form') | |||
There was a problem hiding this comment.
Okay, let me introduce you FormidableForm , our Python Builder in order to generate Formidable objects.
I don't know how you are familiar with Django Form, but Formidable project provides a way to generate data test easily. In order to have more consistent data, I suggest to have a Form with appropriate field which actually match your presets Arguments.
So, you can start to import (if its not the case),
from formidable.forms import FormidableForm, fields
Begin with declaring a new form in your method, and add appropriate fields.
class MyAwesomeForm(FormidableForm):
Field_A = fields.IntegerField()Then you are able to generate the appropriate Formidable objects
formidable = MyAwesomeForm.to_formidable(label='my_test_form')Now you can plug the validations presets in it.
Improve tests to use this new syntax
```
class MyTestForm(FormidableForm):
first_name = fields.CharField()
last_name = fields.CharField()
class Meta:
presets = [
ConfirmationPresets(
[PresetBoundArgument('left', field_id='first_name'),
PresetBoundArgument('right', value='Obi-Wan')],
message='first'),
ConfirmationPresets(
[PresetBoundArgument('left', field_id='last_name'),
PresetBoundArgument('right', value='Kenobi')],
message='last')
]
```
mgu
force-pushed
the
173_ContextFormSerializer_misses_presets_fields
branch
from
63f3d25
to
2f860ad
Compare
moumoutte
deleted the
173_ContextFormSerializer_misses_presets_fields
branch
refs #173