Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin libs #136

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Unpin libs #136

merged 1 commit into from
Jan 19, 2022

Conversation

alyohea
Copy link
Contributor

@alyohea alyohea commented Jan 19, 2022

Closes #135

Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

@codecov
Copy link

codecov bot commented Jan 19, 2022 •
edited
Loading

Codecov Report

Merging #136 (50b138f) into master (7c91890) will not change coverage.
The diff coverage is n/a.

❗ Current head 50b138f differs from pull request most recent head 1d2ac34. Consider uploading reports for the commit 1d2ac34 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files          15       15           
  Lines         653      653           
  Branches       94       94           
=======================================
  Hits          596      596           
  Misses         47       47           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c91890...1d2ac34. Read the comment docs.

@alyohea alyohea marked this pull request as ready for review January 19, 2022 10:36
@alyohea alyohea requested review from matacoder and a team as code owners January 19, 2022 10:36
ewjoachim
ewjoachim approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you unpin the other libs too ?

@alyohea alyohea changed the title Unpin click version Unpin libs Jan 19, 2022
@ewjoachim ewjoachim mentioned this pull request Jan 19, 2022
Closed
4 tasks
@alyohea alyohea force-pushed the unpin-click branch 2 times, most recently from 50b138f to 1d2ac34 Compare January 19, 2022 12:06
@alyohea alyohea merged commit cde9119 into master Jan 19, 2022
@ewjoachim ewjoachim deleted the unpin-click branch January 19, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewjoachim ewjoachim ewjoachim approved these changes

@matacoder matacoder Awaiting requested review from matacoder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update click requirements
2 participants
@alyohea @ewjoachim