Pathlib

[ewjoachim]

#29 but there's still work to do

Successful PR Checklist:

• Tests < though pretty sure not 100% coverage
• Documentation (optionally: run spell checking)
• Had a good time contributing? (feel free to give some feedback)

[codecov]

Codecov Report

Merging #43 into master will decrease coverage by 32.39%.
The diff coverage is 79.22%.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   88.96%   56.56%   -32.4%     
==========================================
  Files          13       13              
  Lines         580      594      +14     
  Branches       72       81       +9     
==========================================
- Hits          516      336     -180     
- Misses         49      251     +202     
+ Partials       15        7       -8

Flag	Coverage Δ
#integration	11.27% <25.97%> (-69.93%)	⬇️
#unit	55.38% <70.12%> (-1.17%)	⬇️

Impacted Files	Coverage Δ
septentrion/cli.py	0% <0%> (-79.23%)	⬇️
septentrion/migrate.py	0% <0%> (-79.23%)	⬇️
septentrion/runner.py	79.59% <71.42%> (-15.31%)	⬇️
septentrion/core.py	71.83% <75%> (-3.54%)	⬇️
septentrion/files.py	86.79% <88.09%> (-13.21%)	⬇️
septentrion/configuration.py	76.56% <94.11%> (-12.12%)	⬇️
septentrion/db.py	42.18% <0%> (-54.69%)	⬇️
septentrion/__main__.py	0% <0%> (-33.34%)	⬇️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc0eb12...b19ada6. Read the comment docs.

[ewjoachim]

The drop in coverage is because we stopped counting our acceptance test in the coverage.

[mgu]

LGTM.
You left some TODOs in the code, do you plan to fix them in an upcoming PR ?

[ewjoachim]

You left some TODOs in the code, do you plan to fix them in an upcoming PR ?

Yes, I'm experimenting a mind blowing new way of coding where I don't try to jam everything in the same PR, looks amazing right ? 😁 I'm also opening tickets, but sometimes, it's so much easier to plant a few TODOs. I plan that we tackle these in the next weeks/months, as part of the current stream of refactor works.